Feature: Added support to detect device type from new broadcasted discovery message from scifi-server#156
Open
calvinleng-science wants to merge 11 commits intomainfrom
Open
Feature: Added support to detect device type from new broadcasted discovery message from scifi-server#156calvinleng-science wants to merge 11 commits intomainfrom
calvinleng-science wants to merge 11 commits intomainfrom
Conversation
…covery message from scifi-server.
calvinleng-science
requested review from
slagernate
and removed request for
gilbert-sci
added 8 commits
October 2, 2025 17:13
namthor9
approved these changes
Nov 3, 2025
Contributor
namthor9
left a comment
namthor9
left a comment
There was a problem hiding this comment.
looks good - lets make sure deploy to pip is hooked up so that we can get this out to users
Contributor
Author
gonna put this on hold for a bit bc this might take a while to figure out safely, also axon tree test + entire axon terminal backend needs testing before im able to merge them to main. scifi2-unique features in the backend won't be in charge of too many things, so i can prob omit this until after sfn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server now sends discovery broadcast messages with an additional field containing information about its device type. /utils/discover.py and /cli/discover.py have been updated to accommodate for this.